Metrics streaming support #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested a bit in dev env and got a few errors during streaming and some data out of range. Might be related to changes in dev environment but just wandering if we should be more resilient to malformed responses and errors: Screen.Recording.2025-02-03.at.17.57.57.movAlso there's "stop streaming" button that doesn't seem to stop streaming 🤔 
|
joey-grafana
requested changes
Feb 11, 2025
There was a problem hiding this comment.
Looking good but have two requests before we can merge;
- There is a flicker on the homepage slow traces column as the results are streaming in. We should remove that so only the rows update in the card itself (like the errors card).
- There is no loading state cards for streaming queries but there is a pause with a blank space before the results start streaming in.
…l with slow services
…ng-support # Conflicts: # src/components/Explore/layouts/attributeBreakdown.ts
joey-grafana
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to grafana/grafana#99037